sqllogictest runner for DF and DuckDB on Vortex#6273
Merged
Conversation
AdamGS
force-pushed
the
adamg/sqllogictest-runner
branch
2 times, most recently
from
7b6bccf to
9dd8b48
Compare
AdamGS
added
changelog/feature
Merging this PR will not alter performance
Comparing 
Footnotes
|
AdamGS
force-pushed
the
adamg/sqllogictest-runner
branch
from
0d43c0b to
f2f1fae
Compare
AdamGS
changed the title
AdamGS
force-pushed
the
adamg/sqllogictest-runner
branch
2 times, most recently
from
7ea17b1 to
a1ba848
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/sqllogictest-runner
branch
from
a1ba848 to
e609774
Compare
vortex-sqllogictest/src/duckdb.rs
Outdated
| pub fn try_new(pb: ProgressBar) -> Result<Self, DuckDBTestError> { | ||
| let dir = tempdir().map_err(|e| DuckDBTestError::Other(e.to_string()))?; | ||
| let config = Config::new()?; | ||
| let db = Database::open_with_config(dir.path().join("duckdb.db"), config)?; |
| }), | ||
| }) | ||
| } | ||
| fn normalize_column_type(dtype: LogicalType) -> DFColumnType { |
joseph-isaacs
approved these changes
Feb 11, 2026
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
lg, I really think we should handle clean up ASAP
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
a10y
reviewed
Feb 11, 2026
| .build()? | ||
| .block_on(run_all())?; | ||
| Ok(()) | ||
| } |
Contributor
There was a problem hiding this comment.
any reason not to use the macro?
Contributor
Author
There was a problem hiding this comment.
not that I can remember
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Contributor
Author
|
to address @joseph-isaacs comment from before, I've added examples/readme about how to use temp directories for storage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR closes an open issue or discussion?
What changes are included in this PR?
The main change in this PR is the introduction of the
vortex-sqllogictestcrate (not intended for publication), which introduces a new way of writing tests by defining slt scripts that are run by both DuckDB and DataFusion.It includes one very small test which we can keep building upon.
It also includes a few changes to
vortex-duckdbto facilitate exposing the information.What is the rationale for this change?
We often rely on our benchmarks to test some codepaths that we can't successfully trigger from traditional tests, this tool allows us to minimize those cases more effectively and in a reproducible way.
It also helps us make sure that we produce the same data on different integrations, and that we're aligned with their Parquet implementation, at least to the degree that the tools themselves provide the same semantics.
How is this change tested?
It adds a downstream test.
Are there any user-facing changes?
Adds some minor functionality to
vortex-duckdb, which is a private crate.